Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934347Ab3E1OaM (ORCPT ); Tue, 28 May 2013 10:30:12 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:61104 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934279Ab3E1OaK (ORCPT ); Tue, 28 May 2013 10:30:10 -0400 From: Kevin Hilman To: Aida Mynzhasova Cc: linux-omap@vger.kernel.org, tony@atomide.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP: fix IVA2 module base address References: <1369741577-21984-1-git-send-email-aida.mynzhasova@skitlab.ru> Date: Tue, 28 May 2013 07:30:05 -0700 In-Reply-To: <1369741577-21984-1-git-send-email-aida.mynzhasova@skitlab.ru> (Aida Mynzhasova's message of "Tue, 28 May 2013 15:46:17 +0400") Message-ID: <87bo7vdvo2.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1395 Lines: 39 Aida Mynzhasova writes: > This patch corrects the base address of IVA2 module on omap3430. > > Signed-off-by: Aida Mynzhasova I know it looks a bit weird to have a negative offset like this, but it's actually correct. These offsets are used relative to prm_base (on 34xx, it's OMAP3430_PRM_BASE defined in omap34xx.h). So I suggest you double check the values there, and cross reference to the "PRCM Register Manual" section of the TRM (last section of the PRCM chapter.) Thanks, Kevin > --- > arch/arm/mach-omap2/prcm-common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/prcm-common.h b/arch/arm/mach-omap2/prcm-common.h > index c7d355f..d5ec044 100644 > --- a/arch/arm/mach-omap2/prcm-common.h > +++ b/arch/arm/mach-omap2/prcm-common.h > @@ -37,7 +37,7 @@ > #define OMAP2430_MDM_MOD 0xc00 > > /* IVA2 module is < base on 3430 */ > -#define OMAP3430_IVA2_MOD -0x800 > +#define OMAP3430_IVA2_MOD 0x800 > #define OMAP3430ES2_SGX_MOD GFX_MOD > #define OMAP3430_CCR_MOD PLL_MOD > #define OMAP3430_DSS_MOD 0x600 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/