Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 1 Oct 2002 13:29:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 1 Oct 2002 13:28:54 -0400 Received: from mg03.austin.ibm.com ([192.35.232.20]:39850 "EHLO mg03.austin.ibm.com") by vger.kernel.org with ESMTP id ; Tue, 1 Oct 2002 13:27:35 -0400 Date: Tue, 1 Oct 2002 12:30:38 -0500 (CDT) From: Kent Yoder To: Jeff Garzik cc: linux-kernel@vger.kernel.org, Subject: Re: [PATCH] pcnet32 cable status check In-Reply-To: <3D99D923.5080200@pobox.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 32 Thus Spake Jeff Garzik: > >Looks good ;-) Thanks, > >One small thing -- since you appear to test all cases for (lp->mii) >before calling mod_timer, I don't think you need to test lp->mii inside >the timer... Well, the reason I left that in there was so that another person could add functionality to the watchdog if they wanted on a non-mii enabled card without having to know that the check would need to be added. If that's not that big a deal, I can remove it... >As Felipe mentioned, using the link interrupt instead of a timer is >preferred -- but my own preference would be to apply your patch with the >small remove-lp->mii-check fixup, and then investigate the support of >link interrupts. The reasoning is that, pcnet32 covers a ton of chips, >and not all may support a link interrupt. > > Jeff > > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/