Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934775Ab3E1QcO (ORCPT ); Tue, 28 May 2013 12:32:14 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:40227 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934675Ab3E1QcM (ORCPT ); Tue, 28 May 2013 12:32:12 -0400 MIME-Version: 1.0 In-Reply-To: <20130528113617.GR14575@console-pimps.org> References: <1369215782-32697-1-git-send-email-matt@console-pimps.org> <20130528113617.GR14575@console-pimps.org> From: Bjorn Helgaas Date: Tue, 28 May 2013 10:31:51 -0600 Message-ID: Subject: Re: [PATCH] x86/PCI: setup data may be in highmem To: Matt Fleming Cc: "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Matt Fleming , Matthew Garrett , Seth Forshee , Jesse Barnes , stable@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 804 Lines: 16 On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: >> pcibios_add_device() is mostly called at boot-time, when >> early_ioremap() probably works well. But it's also called when we >> hot-add devices later, and it looks like early_ioremap() will then >> generate warnings because "system_state != SYSTEM_BOOTING". > > Oops. Good point. Is there any reason we can't use ioremap()? I assume Matthew had some reason for avoiding that in the first place, so I hope he'll chime in. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/