Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964790Ab3E1RPp (ORCPT ); Tue, 28 May 2013 13:15:45 -0400 Received: from mail-qe0-f46.google.com ([209.85.128.46]:52650 "EHLO mail-qe0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934735Ab3E1RPm (ORCPT ); Tue, 28 May 2013 13:15:42 -0400 MIME-Version: 1.0 In-Reply-To: <1369715506.2034.30.camel@joe-AO722> References: <1369599557-22677-1-git-send-email-atomlin@redhat.com> <51A39A3F.8080903@redhat.com> <1369693520.3301.477.camel@edumazet-glaptop> <1369715506.2034.30.camel@joe-AO722> Date: Tue, 28 May 2013 13:15:41 -0400 Message-ID: Subject: Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets From: Debabrata Banerjee To: Joe Perches Cc: Eric Dumazet , Rik van Riel , atomlin@redhat.com, "netdev@vger.kernel.org" , "davem@davemloft.net" , edumazet@google.com, pshelar@nicira.com, mst@redhat.com, alexander.h.duyck@intel.com, aquini@redhat.com, sergei.shtylyov@cogentembedded.com, "linux-kernel@vger.kernel.org" , "Banerjee, Debabrata" , Joshua Hunt Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 26 On Tue, May 28, 2013 at 12:31 AM, Joe Perches wrote: > > I think the __alloc_skb alloc failure message is ok, > but maybe there shouldn't be something "scary" like > a dump_stack. > > Maybe this site should use a trivial debug error > message like below instead. The stack trace may or may not be important for debugging, however what is important is that we know how often this is happening. That implies that there should be a percpu counter of allocation failures here, regardless of a dump_stack, rate limited or not. I would suppose it's ok for no stack by default as long as there is a counter, for this specific call only. There are some scary ways this code is called, for example from tcp_send_fin(). It does yield() in that loop, but otherwise it just spins. -Deb -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/