Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964809Ab3E1R3R (ORCPT ); Tue, 28 May 2013 13:29:17 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:40816 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964786Ab3E1R3O (ORCPT ); Tue, 28 May 2013 13:29:14 -0400 MIME-Version: 1.0 In-Reply-To: <20130528164801.GA2345@srcf.ucam.org> References: <1369215782-32697-1-git-send-email-matt@console-pimps.org> <20130528113617.GR14575@console-pimps.org> <20130528164801.GA2345@srcf.ucam.org> From: Bjorn Helgaas Date: Tue, 28 May 2013 11:28:54 -0600 Message-ID: Subject: Re: [PATCH] x86/PCI: setup data may be in highmem To: Matthew Garrett Cc: Matt Fleming , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Matt Fleming , Seth Forshee , Jesse Barnes , stable@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 27 On Tue, May 28, 2013 at 10:48 AM, Matthew Garrett wrote: > On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: >> On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: >> > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: >> >> pcibios_add_device() is mostly called at boot-time, when >> >> early_ioremap() probably works well. But it's also called when we >> >> hot-add devices later, and it looks like early_ioremap() will then >> >> generate warnings because "system_state != SYSTEM_BOOTING". >> > >> > Oops. Good point. Is there any reason we can't use ioremap()? >> >> I assume Matthew had some reason for avoiding that in the first place, >> so I hope he'll chime in. > > I have no recollection of why I did it that way. If this is all > happening late enough for ioremap() to work then that sounds fine. OK, hopefully somebody will do the analysis to verify that ioremap() is appropriate in both cases. It seems likely, but I haven't looked in detail. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/