Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463Ab3E1TQP (ORCPT ); Tue, 28 May 2013 15:16:15 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:35840 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754017Ab3E1TQO (ORCPT ); Tue, 28 May 2013 15:16:14 -0400 Date: Tue, 28 May 2013 20:16:08 +0100 From: Lee Jones To: Leon Romanovsky Cc: Andy Shevchenko , Samuel Ortiz , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc Message-ID: <20130528191608.GB3012@gmail.com> References: <1368609586-20905-1-git-send-email-leon@leon.nu> <20130523083751.GC22683@gmail.com> <20130528090213.GB22683@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 39 On Tue, 28 May 2013, Leon Romanovsky wrote: > On Tue, May 28, 2013 at 7:24 PM, Andy Shevchenko > wrote: > > On Tue, May 28, 2013 at 12:02 PM, Lee Jones wrote: > >> On Mon, 27 May 2013, Leon Romanovsky wrote: > > > >>> > > + init_data = devm_kzalloc(&tps65912->dev, > > > > There is an obvious typo: no need of & here if I got it correctly. > > > >> drivers/mfd/tps65912-core.c: In function ‘tps65912_device_init’: > >> drivers/mfd/tps65912-core.c:131:18: warning: passing argument 1 of ‘devm_kzalloc’ from incompatible pointer type [enabled by default] > >> In file included from include/linux/platform_device.h:14:0, > >> from include/linux/mfd/core.h:17, > >> from drivers/mfd/tps65912-core.c:21: > >> include/linux/device.h:574:14: note: expected ‘struct device *’ but argument is of type ‘struct device **’ > You are absolutely right, I sent the wrong patch with typo :( > > Lee, > Do I need to resend it ? Or you can fix it by yourself ? I've already fixed it up and tested. I just wanted to clarify exactly what happened, as it couldn't have been tested. No worries, patch applied. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/