Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758248Ab3E1VlW (ORCPT ); Tue, 28 May 2013 17:41:22 -0400 Received: from mail-oa0-f46.google.com ([209.85.219.46]:40802 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757627Ab3E1VlT (ORCPT ); Tue, 28 May 2013 17:41:19 -0400 MIME-Version: 1.0 In-Reply-To: <20130528205842.GE32085@xanatos> References: <20130524210503.GC15788@xanatos> <20130528205842.GE32085@xanatos> Date: Tue, 28 May 2013 14:41:18 -0700 X-Google-Sender-Auth: n6H4Mr2-tUSITEUzKCmDda4roEc Message-ID: Subject: Re: [PATCH] usb: xhci: Disable runtime PM suspend for quirky controllers. From: Julius Werner To: Sarah Sharp Cc: Shawn Nematbakhsh , Alan Stern , linux-usb@vger.kernel.org, Greg Kroah-Hartman , LKML , Julius Werner Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 15 The policy we want to achieve is to disable runtime PM iff there is a device connected that doesn't have persist_enabled or a reset_resume() handler and whose parent/root hub resets on resume, right? So couldn't we remove the HCD-specific XHCI_RESET_ON_RESUME and set the (existing) generic USB_QUIRK_RESET_RESUME on the root hub instead? Then we could handle all of this in the USB core (during device initialization and when changing persist_enabled through sysfs) by just checking for udev->reset_resume on all parent hubs of the device in question (and use pm_runtime_get/put() on said device to prevent its parents from suspending as appropriate). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/