Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759426Ab3E2Cmt (ORCPT ); Tue, 28 May 2013 22:42:49 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:5155 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759366Ab3E2Cms (ORCPT ); Tue, 28 May 2013 22:42:48 -0400 Message-ID: <51A56AA6.9030706@huawei.com> Date: Wed, 29 May 2013 10:40:38 +0800 From: Libo Chen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Andy Shevchenko CC: , , , Bill Pemberton , , , LKML , Andrew Morton , Li Zefan Subject: Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash References: <1367743225-3484-1-git-send-email-libo.chen@huawei.com> <519C40A8.1070506@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.135.72.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 57 On 2013/5/28 23:29, Andy Shevchenko wrote: > This is good fix, but I rather prefer not to see it in this shape. > See comments below. > > On Wed, May 22, 2013 at 6:51 AM, Libo Chen wrote: >> >> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. >> >> Signed-off-by: Libo Chen >> Acked-by: Rafał Miłecki >> --- >> drivers/mtd/devices/bcm47xxsflash.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> * add Acked-by: Rafał Miłecki >> * change send list >> >> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c >> index 9526628..4aa9141 100644 >> --- a/drivers/mtd/devices/bcm47xxsflash.c >> +++ b/drivers/mtd/devices/bcm47xxsflash.c >> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev) >> return 0; >> >> err_dev_reg: >> - kfree(&b47s->mtd); >> + kfree(b47s); >> out: >> return err; >> } > > What about to switch to devm_* and remove those labels and kfrees at all? > > Additionally you can add another patch to use module_platform_driver() > macro instead of module_init/exit. > ok, I will update later. thanks, Libo > -- > With Best Regards, > Andy Shevchenko > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/