Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966357Ab3E2T2F (ORCPT ); Wed, 29 May 2013 15:28:05 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:56734 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S965341Ab3E2T14 (ORCPT ); Wed, 29 May 2013 15:27:56 -0400 Date: Wed, 29 May 2013 15:27:55 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Takashi Iwai cc: alsa-devel@alsa-project.org, Kernel development list Subject: Improving or replacing snd_printk() Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 27 Takashi: Messages produced by snd_printk() aren't as informative as they could be -- especially when CONFIG_SND_VERBOSE_PRINTK isn't enabled, which is the case on most systems. The routine uses printk() rather then dev_dbg(), dev_info(), or dev_err(). As a result, the messages don't say what driver or device is involved. We just get something like: [15919.883604] cannot submit urb (err = -18) That's not much help to anybody. If you didn't know what an urb was, you wouldn't even realize that this referred to a USB device. And if you had multiple USB audio devices, you wouldn't know which one it referred to. Has there been any thought of improving snd_printk(), or even better, changing the call sites to use the dev_*() routines instead? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/