Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935158Ab3E2TwA (ORCPT ); Wed, 29 May 2013 15:52:00 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:49345 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758477Ab3E2Tvx (ORCPT ); Wed, 29 May 2013 15:51:53 -0400 Message-ID: <1369857112.22004.119.camel@joe-AO722> Subject: Re: Improving or replacing snd_printk() From: Joe Perches To: Alan Stern Cc: Takashi Iwai , alsa-devel@alsa-project.org, Kernel development list Date: Wed, 29 May 2013 12:51:52 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 18 On Wed, 2013-05-29 at 15:27 -0400, Alan Stern wrote: > Has there been any thought of improving snd_printk(), or even better, > changing the call sites to use the dev_*() routines instead? Perhaps better would be to add and use some combination of type specific logging message functions/macros like: void snd_(const struct snd_device *dev, const char *fmt, ...) void snd_card_(const struct snd_card *card, const char *fmt, ...) void snd_ac97_(const struct snd_ac97 *ac97, const char *fmt, ...) allowing NULL as the type pointer when necessary/appropriate. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/