Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966870Ab3E2Ucz (ORCPT ); Wed, 29 May 2013 16:32:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48370 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966083Ab3E2Ucp (ORCPT ); Wed, 29 May 2013 16:32:45 -0400 Date: Wed, 29 May 2013 16:32:38 -0400 From: Don Zickus To: Sarah Sharp Cc: Julius Werner , Shawn Nematbakhsh , Alan Stern , linux-usb@vger.kernel.org, Greg Kroah-Hartman , LKML , Oliver Neukum Subject: Re: [PATCH] usb: xhci: Disable runtime PM suspend for quirky controllers. Message-ID: <20130529203238.GC133453@redhat.com> References: <20130524210503.GC15788@xanatos> <20130528205842.GE32085@xanatos> <20130529193828.GK32085@xanatos> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130529193828.GK32085@xanatos> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 35 On Wed, May 29, 2013 at 12:38:28PM -0700, Sarah Sharp wrote: > On Tue, May 28, 2013 at 02:41:18PM -0700, Julius Werner wrote: > > The policy we want to achieve is to disable runtime PM iff there is a > > device connected that doesn't have persist_enabled or a reset_resume() > > handler and whose parent/root hub resets on resume, right? > > Makes sense. However, not all distros may want that policy, so there > should be a way to change that policy via sysfs. Some distros may > choose to take the power savings over having a particular USB device > work, especially in the server market. > > Don, Oliver, what do you think of this patch: > http://marc.info/?l=linux-usb&m=136941922715772&w=2 That is limited only to certain controllers right? RHEL6 doesn't support runtime suspend, so we don't hear to many complaints. Most of our server customers don't have much plugged into USB, so I don't expect much problems there. Our laptop customers prefer the power savings, but I don't know how many of them have chipsets with XHCI_RESET_ON_RESUME. > > Julius is proposing to limit the scope of the patch a bit, but the > impact will still be that TI hosts will be active more often than not. Hmm, for some reason I don't see TI having the XHCI_RESET_ON_RESUME quirk set, just VIA and ETRON. Neither of which seem to be normally shipped with servers. Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/