Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966915Ab3E2Ufh (ORCPT ); Wed, 29 May 2013 16:35:37 -0400 Received: from smtp65.ord1c.emailsrvr.com ([108.166.43.65]:44612 "EHLO smtp65.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966083Ab3E2Uf3 (ORCPT ); Wed, 29 May 2013 16:35:29 -0400 X-Greylist: delayed 17045 seconds by postgrey-1.27 at vger.kernel.org; Wed, 29 May 2013 16:35:29 EDT Message-ID: <51A66690.6060109@calxeda.com> Date: Wed, 29 May 2013 15:35:28 -0500 From: Mark Langsdorf User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Timur Tabi CC: lkml , Tejun Heo , "linux-ide@vger.kernel.org" Subject: Re: [PATCH] ata: increase retry count but shorten duration for Calxeda controller References: <1369842679-9680-1-git-send-email-mark.langsdorf@calxeda.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 31 On 05/29/2013 03:12 PM, Timur Tabi wrote: > On Wed, May 29, 2013 at 10:51 AM, Mark Langsdorf > wrote: >> >> { >> - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context); >> + unsigned long timing[] = { 5, 100, 500}; > > > You didn't address my comments the last time you posted this. I'll > post them again: > > > Why are you dropping the 'const'? > > Assuming it works, this should be more efficient: > > static const unsigned long timing[] = {5, 100, 500}; I thought there was a compile issue, but I just rechecked and there wasn't. I'll fix for the next submission. Thanks for the review. --Mark Langsdorf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/