Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935197Ab3E2Vnr (ORCPT ); Wed, 29 May 2013 17:43:47 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:50672 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935180Ab3E2Vni (ORCPT ); Wed, 29 May 2013 17:43:38 -0400 Message-ID: <51A6768B.5050603@cogentembedded.com> Date: Thu, 30 May 2013 01:43:39 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Davidlohr Bueso CC: "David S. Miller" , Eric Dumazet , netdev@vger.kernel.org, LKML Subject: Re: [PATCH] net: skbuff: use _RET_IP_ References: <1369861743.4188.33.camel@buesod1.americas.hpqcorp.net> In-Reply-To: <1369861743.4188.33.camel@buesod1.americas.hpqcorp.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 36 Hello. On 05/30/2013 01:09 AM, Davidlohr Bueso wrote: > Use the already defined macro to pass the function return address. > > Signed-off-by: Davidlohr Bueso > --- > net/core/skbuff.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index af9185d..0d06850 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -116,22 +116,22 @@ static const struct pipe_buf_operations sock_pipe_buf_ops = { > * Keep out of line to prevent kernel bloat. > * __builtin_return_address is not used because it is not always reliable. > */ > -static void skb_panic(struct sk_buff *skb, unsigned int sz, void *addr, > +static void skb_panic(struct sk_buff *skb, unsigned int sz, unsigned long addr, > const char msg[]) > { > - pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n", > + pr_emerg("%s: text:0x%lx len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n", Why not "text:%#lx" as already used in this string? It's equivalent to "0x%lx". WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/