Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967171Ab3E2XH4 (ORCPT ); Wed, 29 May 2013 19:07:56 -0400 Received: from mga09.intel.com ([134.134.136.24]:57930 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966322Ab3E2XHt (ORCPT ); Wed, 29 May 2013 19:07:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,766,1363158000"; d="scan'208";a="345343038" From: "Luck, Tony" To: "Rafael J. Wysocki" , Lance Ortiz CC: "bhelgaas@google.com" , "lance_ortiz@hotmail.com" , "jiang.liu@huawei.com" , "bp@alien8.de" , "rostedt@goodmis.org" , "mchehab@redhat.com" , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3] aerdrv: Move cper_print_aer() call out of interrupt context Thread-Topic: [PATCH v3] aerdrv: Move cper_print_aer() call out of interrupt context Thread-Index: AQHOXKB4VO1K+Vpt70q3tQ/opKKdDJkdOXqA//+M9oA= Date: Wed, 29 May 2013 23:07:47 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F2DA70112@ORSMSX106.amr.corp.intel.com> References: <20130529190326.24171.86905.stgit@grignak.americas.hpqcorp.net> <30463843.EmBn1xaq3I@vostro.rjw.lan> In-Reply-To: <30463843.EmBn1xaq3I@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r4TN802c013682 Content-Length: 777 Lines: 14 > + /* > + * TODO: This function needs to be re-written so that it's output > + * matches the output of aer_print_error(). Right now, the output > + * is formatted very differently. > + */ So we have this big "TODO" comment sitting there very prominently ... which Linus is bound to ask about if I ask him to pull this into 3.10-rcX ... what's the impact of this? What should I say when he asks why should he pull this fix into 3.10 when there is still some work to do? Is matching the output no big deal and can wait for some future, while moving the pci bits to the work function needs to go in now? -Tony ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?