Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967156Ab3E2XP3 (ORCPT ); Wed, 29 May 2013 19:15:29 -0400 Received: from [207.46.163.26] ([207.46.163.26]:32616 "EHLO co9outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S966668Ab3E2XPV convert rfc822-to-8bit (ORCPT ); Wed, 29 May 2013 19:15:21 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -4 X-BigFish: VS-4(zzbb2dI98dI9371I1432Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzzz2dh2a8h668h839h944hd2bhf0ah1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h16a6h1758h1898h18e1h1946h19b5h1ad9h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1155h) Date: Wed, 29 May 2013 18:14:32 -0500 From: Scott Wood Subject: Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling To: Alexey Kardashevskiy CC: David Gibson , , , , Alexander Graf , Paul Mackerras , References: <1369763138.18630.3@snotra> <51A53E20.3020205@ozlabs.ru> <1369784115.18630.27@snotra> <51A547F0.8090406@ozlabs.ru> <1369857949.18630.42@snotra> <51A68AE9.6070709@ozlabs.ru> In-Reply-To: <51A68AE9.6070709@ozlabs.ru> (from aik@ozlabs.ru on Wed May 29 18:10:33 2013) X-Mailer: Balsa 2.4.12 Message-ID: <1369869272.18630.47@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: 8BIT X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2149 Lines: 60 On 05/29/2013 06:10:33 PM, Alexey Kardashevskiy wrote: > On 05/30/2013 06:05 AM, Scott Wood wrote: > > On 05/28/2013 07:12:32 PM, Alexey Kardashevskiy wrote: > >> On 05/29/2013 09:35 AM, Scott Wood wrote: > >> > On 05/28/2013 06:30:40 PM, Alexey Kardashevskiy wrote: > >> >> >> >>> @@ -939,6 +940,9 @@ struct kvm_s390_ucas_mapping { > >> >> >> >>> #define KVM_GET_DEVICE_ATTR _IOW(KVMIO, 0xe2, > struct > >> >> >> >>> kvm_device_attr) > >> >> >> >>> #define KVM_HAS_DEVICE_ATTR _IOW(KVMIO, 0xe3, > struct > >> >> >> >>> kvm_device_attr) > >> >> >> >>> > >> >> >> >>> +/* ioctl for SPAPR TCE IOMMU */ > >> >> >> >>> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xe4, > struct > >> >> >> >>> kvm_create_spapr_tce_iommu) > >> >> >> >> > >> >> >> >> Shouldn't this go under the vm ioctl section? > >> >> >> > >> >> >> > >> >> >> The KVM_CREATE_SPAPR_TCE_IOMMU ioctl (the version for > emulated > >> >> devices) is > >> >> >> in this section so I decided to keep them together. Wrong? > >> >> > > >> >> > You decided to keep KVM_CREATE_SPAPR_TCE_IOMMU together with > >> >> > KVM_CREATE_SPAPR_TCE_IOMMU? > >> >> > >> >> Yes. > >> > > >> > Sigh. That's the same thing repeated. There's only one IOCTL. > >> Nothing is > >> > being "kept together". > >> > >> Sorry, I meant this ioctl - KVM_CREATE_SPAPR_TCE. > > > > But you didn't put it in the same section as KVM_CREATE_SPAPR_TCE. > 0xe0 > > begins a different section. > > It is not really obvious that there are sections as no comment defines > those :) There is a comment /* ioctls for fds returned by KVM_CREATE_DEVICE */ Putting KVM_CREATE_DEVICE in there was mainly to avoid dealing with the ioctl number conflict mess in the vm-ioctl section, but at least that one is related to the device control API. :-) > But yes, makes sense to move it up a bit and change the code to 0xad. 0xad is KVM_KVMCLOCK_CTRL -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/