Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967768Ab3E3HOd (ORCPT ); Thu, 30 May 2013 03:14:33 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:43587 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S967668Ab3E3HO0 (ORCPT ); Thu, 30 May 2013 03:14:26 -0400 Message-ID: <1369898064.22004.134.camel@joe-AO722> Subject: Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff From: Joe Perches To: liguang Cc: Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Thu, 30 May 2013 00:14:24 -0700 In-Reply-To: <1369897651-23770-1-git-send-email-lig.fnst@cn.fujitsu.com> References: <1369897651-23770-1-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 800 Lines: 23 On Thu, 2013-05-30 at 15:07 +0800, liguang wrote: > orderly_poweroff is expecting a bool parameter, so > use 'ture' instead '1' [] > diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c [] > @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log) > > case EPOW_SYSTEM_HALT: > pr_emerg("Firmware initiated power off"); > - orderly_poweroff(1); > + orderly_poweroff(ture); > break; Compile your patches _before_ submitting them please. "true" not "ture" here and in the commit message. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/