Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967789Ab3E3HZX (ORCPT ); Thu, 30 May 2013 03:25:23 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:59578 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967687Ab3E3HZQ (ORCPT ); Thu, 30 May 2013 03:25:16 -0400 Message-ID: <51A6FEA8.5030704@ti.com> Date: Thu, 30 May 2013 09:24:24 +0200 From: Benoit Cousson Organization: Texas Instruments User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Gupta, Pekon" CC: Tony Lindgren , "linux-mtd@lists.infradead.org" , "linux@arm.linux.org.uk" , "Philip, Avinash" , "linux-omap@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Hebbar, Gururaja" , "Hiremath, Vaibhav" , "zonque@gmail.com" , "jacmet@sunsite.dk" , "Nori, Sekhar" Subject: Re: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm References: <517F5126.5000509@ti.com> <20130508235404.GX32546@atomide.com> <20980858CB6D3A4BAE95CA194937D5E73E9C320D@DBDE04.ent.ti.com> <20980858CB6D3A4BAE95CA194937D5E73E9C5629@DBDE04.ent.ti.com> In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73E9C5629@DBDE04.ent.ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 50 Hi Pekon, On 05/20/2013 06:44 AM, Gupta, Pekon wrote: > >>>>> >>>>> am33xx_pinmux: pinmux@44e10800 { >>>>> pinctrl-names = "default"; >>>>> - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; >>>>> + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 >>>>> + &nandflash_pins_s0>; >>>> >>>> Why add this to the board level fallback (called pinctrl hogs, I think)? >>>> This can be part of nand node you added below so that the pinctrl will >>>> take effect when nand gets probed instead of all the time. >>> >>> Yes we should have all the pinctrl entries under the related drivers. >>> This makes it easy remux pins during runtime if needed, and also >>> allows unloading pinctrl-single.ko for development. >>> >> Yes, accepted. This has been already fixed in v3 of this patch set. >> If all fine, then please pull this for next merge.. >> >> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html >> >> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html >> >> http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html >> >> >> with regards, pekon > > Request you to please accept | provide feedbacks on this patch series. > These are waiting acceptance since Jan-2013, and are necessary for > DT based configs for board having NAND support. > > with regards, pekon Sorry, I missed that series. I'm applying it right now. Thanks, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/