Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030581Ab3E3K6w (ORCPT ); Thu, 30 May 2013 06:58:52 -0400 Received: from mx2.parallels.com ([199.115.105.18]:40695 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030459Ab3E3K6o (ORCPT ); Thu, 30 May 2013 06:58:44 -0400 Message-ID: <51A73115.3080605@parallels.com> Date: Thu, 30 May 2013 14:59:33 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: Andrew Morton CC: Andrey Vagin , , , , Konstantin Khlebnikov , Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , Tejun Heo Subject: Re: [PATCH] memcg: don't initialize kmem-cache destroying work for root caches References: <1368535118-27369-1-git-send-email-avagin@openvz.org> <20130528155326.0a8b66a7711746e827d5fdea@linux-foundation.org> <51A56C60.9030306@parallels.com> In-Reply-To: <51A56C60.9030306@parallels.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1922 Lines: 54 On 05/29/2013 06:48 AM, Glauber Costa wrote: > On 05/29/2013 04:23 AM, Andrew Morton wrote: >> On Tue, 14 May 2013 16:38:38 +0400 Andrey Vagin wrote: >> >>> struct memcg_cache_params has a union. Different parts of this union are >>> used for root and non-root caches. A part with destroying work is used only >>> for non-root caches. >> >> That union is a bit dangerous. Perhaps it would be better to do >> something like >> >> --- a/include/linux/slab.h~a >> +++ a/include/linux/slab.h >> @@ -337,15 +337,17 @@ static __always_inline int kmalloc_size( >> struct memcg_cache_params { >> bool is_root_cache; >> union { >> - struct kmem_cache *memcg_caches[0]; >> - struct { >> + struct memcg_root_cache { >> + struct kmem_cache *caches[0]; >> + } memcg_root_cache; >> + struct memcg_child_cache { >> struct mem_cgroup *memcg; >> struct list_head list; >> struct kmem_cache *root_cache; >> bool dead; >> atomic_t nr_pages; >> struct work_struct destroy; >> - }; >> + } memcg_child_cache; >> }; >> }; >> >> And then adopt the convention of selecting either memcg_root_cache or >> memcg_child_cache at the highest level then passing the more strongly >> typed pointer to callees. >> > > Since it is already creating problems, yes, I agree. > > I will try to cook up something soon. > There are other cleanups being requested as well. (Tejun claims that we would be better off with locks than with barriers for the destruction path). To avoid conflicting with the current shrinkers work - that is very massive, and since none of those are pressing, I will try to tackle both next week (on top of that, if possible) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/