Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757350Ab3E3OEQ (ORCPT ); Thu, 30 May 2013 10:04:16 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:61400 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755087Ab3E3OEK (ORCPT ); Thu, 30 May 2013 10:04:10 -0400 Message-ID: <51A75C56.3070704@monstr.eu> Date: Thu, 30 May 2013 16:04:06 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Guenter Roeck CC: Michal Simek , linux-kernel@vger.kernel.org, Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH 2/3] watchdog: xilinx: Setup the origin compatible string References: <20130530140041.GA28232@roeck-us.net> In-Reply-To: <20130530140041.GA28232@roeck-us.net> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2ORRIGTWBHLEINMNBDLUK" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2974 Lines: 82 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2ORRIGTWBHLEINMNBDLUK Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/30/2013 04:00 PM, Guenter Roeck wrote: > On Thu, May 30, 2013 at 02:26:03PM +0200, Michal Simek wrote: >> Watchdog 1.01.a is also compatible with 1.00.a. >> Setup the origin version to compatible list. >> If you want to use newer watchdog version, please >> extend your compatible list. >> >> For example: >> compatible =3D "xlnx,xps-timebase-wdt-1.02.a", "xlnx,xps-timebase-wdt-= 1.00.a"; >> >> Signed-off-by: Michal Simek >> --- >> drivers/watchdog/of_xilinx_wdt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xi= linx_wdt.c >> index d4a35ab..79f358c 100644 >> --- a/drivers/watchdog/of_xilinx_wdt.c >> +++ b/drivers/watchdog/of_xilinx_wdt.c >> @@ -384,7 +384,7 @@ static int xwdt_remove(struct platform_device *dev= ) >> >> /* Match table for of_platform binding */ >> static struct of_device_id xwdt_of_match[] =3D { >> - { .compatible =3D "xlnx,xps-timebase-wdt-1.01.a", }, >> + { .compatible =3D "xlnx,xps-timebase-wdt-1.00.a", }, >=20 > Is this really a good idea ? It means every existing device tree bindin= g which > specifies 1.01a will now fail. If the code is compatible to 1.00a, I th= ink it > would make more sense to add that to the driver as additional entry ins= tead of > deleting the existing entry for 1.01a. The most of users/I believe all of them are using device-tree generator which generate DTS directly from Xilinx design tools because it is almost= impossible to write DTS for any xilinx fpga plaform and 1.00.a is setup as backward compatible property. But if you think that it is worth to keep there 1.01.a I have no problem with that I will keep there 1.01.a and add 1.00.a. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform ------enig2ORRIGTWBHLEINMNBDLUK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGnXFYACgkQykllyylKDCH+fgCdE5WiRVzzYXOLikF5cDQqfpdu KW8An34MARbnqYUboW/6YIUUjuY+Gt8O =xb4H -----END PGP SIGNATURE----- ------enig2ORRIGTWBHLEINMNBDLUK-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/