Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933150Ab3E3OkA (ORCPT ); Thu, 30 May 2013 10:40:00 -0400 Received: from www.linutronix.de ([62.245.132.108]:33736 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932733Ab3E3Ojx (ORCPT ); Thu, 30 May 2013 10:39:53 -0400 Date: Thu, 30 May 2013 16:39:41 +0200 (CEST) From: Thomas Gleixner To: Frederic Weisbecker cc: Ingo Molnar , LKML , Jiri Bohac , Steven Rostedt , "Paul E. McKenney" , Peter Zijlstra , Borislav Petkov Subject: Re: [PATCH] nohz: Prevent broadcast source from stealing full dynticks timekeeping duty In-Reply-To: <20130530142200.GA23384@somewhere> Message-ID: References: <1369845580-15273-1-git-send-email-fweisbec@gmail.com> <1369845580-15273-2-git-send-email-fweisbec@gmail.com> <20130530142200.GA23384@somewhere> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 31 On Thu, 30 May 2013, Frederic Weisbecker wrote: > On Thu, May 30, 2013 at 03:57:17PM +0200, Thomas Gleixner wrote: > > On Wed, 29 May 2013, Frederic Weisbecker wrote: > > > > > The timekeeping duty is currently assigned to the CPU that > > > handles the tick broadcast clock device by the time it is set in > > > one shot mode. > > > > > > The reason for this is not entirely clear as outlined by Jiri > > > Bohac: https://patchwork.kernel.org/patch/2302951/ > > > > > > One could speculate though that it makes sure only one CPU > > > is woken up to fixup the timekeeping max deferment. But the > > > timekeeper can change anytime after the broadcast CPU becomes > > > idle. So probably we can remove this as in Jiri's patch, but > > > not late in the -rc's. > > > > Looking at commit 7300711e (clockevents: broadcast fixup possible > > waiters) which introduced that takeover, I really can't see a reason > > why we must do that. It's safe to remove it completely even now. > > Yeah it seems so, if you're ok I can commit https://patchwork.kernel.org/patch/2302951/ > with your ack and send another pull request. Yup. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/