Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756907Ab3E3SL3 (ORCPT ); Thu, 30 May 2013 14:11:29 -0400 Received: from mga01.intel.com ([192.55.52.88]:11397 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756180Ab3E3SLX (ORCPT ); Thu, 30 May 2013 14:11:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,772,1363158000"; d="scan'208";a="342660417" Date: Thu, 30 May 2013 23:03:26 +0530 From: Vinod Koul To: Linus Walleij Cc: Wei Yongjun , Srinidhi KASAGAR , Dan Williams , Grant Likely , Rob Herring , Wei Yongjun , "linux-arm-kernel@lists.infradead.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe() Message-ID: <20130530173326.GD3767@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1070 Lines: 31 On Thu, May 30, 2013 at 09:41:38AM +0200, Linus Walleij wrote: > On Thu, May 30, 2013 at 6:32 AM, Wei Yongjun wrote: > > > From: Wei Yongjun > > > > In many of the error handling case, the return value 'ret' not set > > and 0 will be return from d40_probe() even if error, but we should > > return a negative error code instead in those error handling case. > > This patch fixed them, and also removed useless variable 'err'. > > > > Signed-off-by: Wei Yongjun > > --- > > v1 -> v2: rebased on linux-next.git > > I've tentatively applied this to my dma40 branch, waiting for Vinod > to ACK it. I though you wanted me to apply this :) Nevertheless, Acked-by: Vinod Koul Can you CC stable too, pls. -- ~Vinod -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/