Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758205Ab3E3SPD (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 May 2013 14:15:03 -0400
Received: from iolanthe.rowland.org ([192.131.102.54]:58251 "HELO
	iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1756886Ab3E3SO5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 May 2013 14:14:57 -0400
Date: Thu, 30 May 2013 14:14:57 -0400 (EDT)
From: Alan Stern <stern@rowland.harvard.edu>
X-X-Sender: stern@iolanthe.rowland.org
To: Joe Perches <joe@perches.com>
cc: Takashi Iwai <tiwai@suse.de>, <alsa-devel@alsa-project.org>,
        Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Improving or replacing snd_printk()
In-Reply-To: <1369857112.22004.119.camel@joe-AO722>
Message-ID: <Pine.LNX.4.44L0.1305301411370.1137-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1173
Lines: 27

On Wed, 29 May 2013, Joe Perches wrote:

> On Wed, 2013-05-29 at 15:27 -0400, Alan Stern wrote:
> > Has there been any thought of improving snd_printk(), or even better,
> > changing the call sites to use the dev_*() routines instead?
> 
> Perhaps better would be to add and use some combination of
> type specific logging message functions/macros like:
> 
> void snd_<level>(const struct snd_device *dev, const char *fmt, ...)
> void snd_card_<level>(const struct snd_card *card, const char *fmt, ...)
> void snd_ac97_<level>(const struct snd_ac97 *ac97, const char *fmt, ...)
> 
> allowing NULL as the type pointer when necessary/appropriate.

Almost anything would be better than the current situation.  The only 
enhancement provided by CONFIG_SND_VERBOSE_PRINTK is to print the 
filename and line number, which is relatively unhelpful (unless there 
are multiple copies of the same message in several places).

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/