Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758801Ab3E3SZb (ORCPT ); Thu, 30 May 2013 14:25:31 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:54062 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630Ab3E3SZX (ORCPT ); Thu, 30 May 2013 14:25:23 -0400 MIME-Version: 1.0 In-Reply-To: <1369206634-6778-10-git-send-email-avinashphilip@ti.com> References: <1369206634-6778-1-git-send-email-avinashphilip@ti.com> <1369206634-6778-10-git-send-email-avinashphilip@ti.com> Date: Thu, 30 May 2013 20:25:22 +0200 Message-ID: Subject: Re: [PATCH 09/11] gpio: davinci: DT changes for driver From: Linus Walleij To: Philip Avinash Cc: "Nori, Sekhar" , ext Kevin Hilman , Russell King - ARM Linux , Grant Likely , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-kernel@vger.kernel.org" , KV Sujith , Rob Herring , Rob Landley , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 38 On Wed, May 22, 2013 at 9:10 AM, Philip Avinash wrote: (...) > +- interrupts: The Starting IRQ number for GPIO > +- intc_irq_num: The number of IRQs supported by the Interrupt Controller (...) No this is not how you pass a number of IRQs in the device tree. "interrupts" is an array. Pass every interrupt here for a full resolution of the IRQs. Further this looks fishy: + interrupts = <42>; Usually you pass flags with the IRQs, I would rather have expected an array like this: interrupts = < 90 0x4 96 0x4 14 0x4 15 0x4 79 0x4>; 0x4 is IRQ_TYPE_LEVEL_HIGH, you can use the dts #include and define that symbolically. Doesn't the DaVinci IRQ controller support *any* IRQ flags? Since the driver code is not reading out the interrupts but (I guess?) falling back to platform data IRQ assignment, this seems wrong. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/