Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759908Ab3E3Way (ORCPT ); Thu, 30 May 2013 18:30:54 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57278 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140Ab3E3Waq (ORCPT ); Thu, 30 May 2013 18:30:46 -0400 Date: Fri, 31 May 2013 00:30:43 +0200 (CEST) From: Jiri Kosina To: Russ Anderson Cc: Matthew Garrett , joeyli , Matt Fleming , "matt.fleming@intel.com" , "linux-efi@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov Subject: Re: [regression, bisected] x86: efi: Pass boot services variable info to runtime code In-Reply-To: <20130530222836.GB11105@sgi.com> Message-ID: References: <20130523115801.GJ14575@console-pimps.org> <20130523203234.GD20913@sgi.com> <20130524074331.GL14575@console-pimps.org> <20130529210115.GC28027@sgi.com> <20130529224645.GA16582@sgi.com> <1369880172.17397.11.camel@linux-s257.site> <20130530221737.GA11105@sgi.com> <1369952512.11620.14.camel@x230> <20130530222836.GB11105@sgi.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 22 On Thu, 30 May 2013, Russ Anderson wrote: > > > That's a great idea. This patch moves the QueryVariableInfo() > > > call from bootime to runtime, in efi_late_init(). The attached > > > patch is consistent with the UEFI spec and avoids the problem. > > > > No, that defeats the entire point of the original patch. > > How so? It is still calling QueryVariableInfo() > before the data is used. You lose information provided by QueryVariableInfo() about boot-only variables once the transition boot -> runtime has happened. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/