Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883Ab3EaCys (ORCPT ); Thu, 30 May 2013 22:54:48 -0400 Received: from relay2.sgi.com ([192.48.179.30]:36928 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752520Ab3EaCyk (ORCPT ); Thu, 30 May 2013 22:54:40 -0400 Date: Thu, 30 May 2013 21:54:38 -0500 From: Russ Anderson To: Matthew Garrett Cc: joeyli , Jiri Kosina , Matt Fleming , "matt.fleming@intel.com" , "linux-efi@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov Subject: Re: [regression, bisected] x86: efi: Pass boot services variable info to runtime code Message-ID: <20130531025438.GB24287@sgi.com> Reply-To: Russ Anderson References: <20130524074331.GL14575@console-pimps.org> <20130529210115.GC28027@sgi.com> <20130529224645.GA16582@sgi.com> <1369880172.17397.11.camel@linux-s257.site> <20130530221737.GA11105@sgi.com> <1369952512.11620.14.camel@x230> <20130530222836.GB11105@sgi.com> <1369953129.11620.15.camel@x230> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369953129.11620.15.camel@x230> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 40 On Thu, May 30, 2013 at 10:32:09PM +0000, Matthew Garrett wrote: > On Thu, 2013-05-30 at 17:28 -0500, Russ Anderson wrote: > > On Thu, May 30, 2013 at 10:21:53PM +0000, Matthew Garrett wrote: > > > On Thu, 2013-05-30 at 17:17 -0500, Russ Anderson wrote: > > > > > > > That's a great idea. This patch moves the QueryVariableInfo() > > > > call from bootime to runtime, in efi_late_init(). The attached > > > > patch is consistent with the UEFI spec and avoids the problem. > > > > > > No, that defeats the entire point of the original patch. > > > > How so? It is still calling QueryVariableInfo() > > before the data is used. > > We want to know how much space is used by variables that aren't visible > at runtime. We want to boot. We could boot up through 3.9-rc7. Knowing how much space is used by variables that aren't visible at runtime it moot if you can't boot. And again, maybe this is a bios bug - we have bios people looking into it - and maybe that call _should_ work, but the fact is the kernel booted without that change[1] and does not boot with it. [1] commit cc5a080c5d40c36089bb08a8a16fa3fc7047fe0f Thanks, -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc rja@sgi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/