Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392Ab3EaC63 (ORCPT ); Thu, 30 May 2013 22:58:29 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35224 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698Ab3EaC6W (ORCPT ); Thu, 30 May 2013 22:58:22 -0400 Message-ID: <51A811C8.9090509@linaro.org> Date: Fri, 31 May 2013 08:28:16 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Olof Johansson CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Arnd Bergmann , Patch Tracking , Kukjin Kim Subject: Re: [PATCH] ARM: EXYNOS: Consolidate multiple low-level UART port definitions References: <1369888827-9427-1-git-send-email-tushar.behera@linaro.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 43 On 05/31/2013 02:41 AM, Olof Johansson wrote: > Hi, > > On Wed, May 29, 2013 at 9:40 PM, Tushar Behera wrote: >> There are two definitions for low-level UART ports for Exynos platform. >> CONFIG_S3C_LOWLEVEL_UART_PORT is used for printing "Uncompressing >> Linux... done, booting the kernel." and CONFIG_S3C_UART for other >> low-level messages. >> >> The assumption for both the uart ports is that they are pre-configured >> in the bootloader. Since they are essentially the same always, it >> would be good to consolidate them to use only one macro, in this case >> 'DEBUG_S3C_UART' would be a better option. >> >> 'DEBUG_S3C_UART' is defined only if DEBUG_LL is enabled. We can safely >> disable this option when DEBUG_LL is not defined and we can boot various >> boards with different UART port settings. Only drawback of this >> approach is that when DEBUG_LL is not defined, we would be missing the >> print "Uncompressing Linux... done, booting the kernel." >> >> Since CONFIG_S3C_LOWLEVEL_UART_PORT is still used by other Samsung >> boards, the consolidation applies only for ARCH_EXYNOS. >> >> Signed-off-by: Tushar Behera > > This looks reasonable, but you have to convert the other samsung > platforms too -- it's not ok to ignore them. > Sure thing. I will update those platforms in a subsequent patchset. > > -Olof > -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/