Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117Ab3EaDXX (ORCPT ); Thu, 30 May 2013 23:23:23 -0400 Received: from mail-vb0-f49.google.com ([209.85.212.49]:61537 "EHLO mail-vb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502Ab3EaDXM (ORCPT ); Thu, 30 May 2013 23:23:12 -0400 MIME-Version: 1.0 In-Reply-To: <5578958b49fff222740711e091c2325100f5a440.1369963643.git.mschiffer@universe-factory.net> References: <51A66CF3.7010202@universe-factory.net> <5578958b49fff222740711e091c2325100f5a440.1369963643.git.mschiffer@universe-factory.net> Date: Fri, 31 May 2013 11:23:11 +0800 Message-ID: Subject: Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb From: Cong Wang To: Matthias Schiffer Cc: David Miller , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Linux Kernel Network Developers , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 17 On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer wrote: > Since some refactoring in 5f5a011, ndisc_send_redirect called > ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or > in the worst case a panic when the skb_put failed. > > Signed-off-by: Matthias Schiffer Good catch! Reviewed-by: Cong Wang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/