Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496Ab3EaHe0 (ORCPT ); Fri, 31 May 2013 03:34:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38695 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195Ab3EaHeU (ORCPT ); Fri, 31 May 2013 03:34:20 -0400 Date: Fri, 31 May 2013 09:35:00 +0200 Message-ID: From: Takashi Iwai To: Joe Perches Cc: Jaroslav Kysela , Alan Stern , alsa-devel@alsa-project.org, Kernel development list Subject: Re: [alsa-devel] Improving or replacing snd_printk() In-Reply-To: <1369985409.10556.51.camel@joe-AO722> References: <51A79F25.6040007@perex.cz> <1369983967.10556.48.camel@joe-AO722> <1369985409.10556.51.camel@joe-AO722> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 28 At Fri, 31 May 2013 00:30:09 -0700, Joe Perches wrote: > > On Fri, 2013-05-31 at 09:23 +0200, Takashi Iwai wrote: > > At Fri, 31 May 2013 00:06:07 -0700, Joe Perches wrote: > > > On Fri, 2013-05-31 at 08:37 +0200, Takashi Iwai wrote: > > > > I think most of snd_printd() and snd_printdd() can be kept as is. > > > > These are just debug messages, after all. > > > Some of those are emitted at levels other than KERN_DEBUG. > > > I think that odd. > > Yeah, they aren't good, but it's a different topic. > > Not really, I think it's systemic and fallout from > accretive implementation rather than design. Maybe. But you shouldn't mix up with the fix for the missing verbosity and the fix for wrong KERN_ prefix, at least, in the patch level. They need to be fixed individually. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/