Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753757Ab3EaHk6 (ORCPT ); Fri, 31 May 2013 03:40:58 -0400 Received: from mail.skyhub.de ([78.46.96.112]:52121 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647Ab3EaHkv (ORCPT ); Fri, 31 May 2013 03:40:51 -0400 Date: Fri, 31 May 2013 09:41:01 +0200 From: Borislav Petkov To: "Ortiz, Lance E" Cc: Steven Rostedt , "Luck, Tony" , "Rafael J. Wysocki" , "bhelgaas@google.com" , "lance_ortiz@hotmail.com" , "jiang.liu@huawei.com" , "mchehab@redhat.com" , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] aerdrv: Move cper_print_aer() call out of interrupt context Message-ID: <20130531074101.GA3379@nazgul.tnic> References: <20130529190326.24171.86905.stgit@grignak.americas.hpqcorp.net> <30463843.EmBn1xaq3I@vostro.rjw.lan> <3908561D78D1C84285E8C5FCA982C28F2DA70112@ORSMSX106.amr.corp.intel.com> <20130530072849.GA20793@pd.tnic> <1369921028.26799.4.camel@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 24 On Thu, May 30, 2013 at 02:04:42PM +0000, Ortiz, Lance E wrote: > Steve, you do have a good point here. I am wondering if that is why > we should consider changing the output to match aer_print_error(). > The code path to aer_print_error() is the more common path where not > as many platforms support the cper_print_error() path (firmware first > AER). So it is more likely that any tools written would know how to > parse the output from aer_print_error(). It would be good for those > tools to support firmware first AER when it becomes more common. Of > course this is purely conjecture. I have no idea if there are any > tools that parse this text output. Whatever you end up doing, just make sure you've hammered out the information going out to userspace to be clear, succinct and complete (as far as possible, of course). Because once you cast it in stone and tools start using it, changing its format is a huge PITA, if at all possible. And if the error formats are compatible, then sharing the format is obviously advantageous. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/