Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753959Ab3EaH6P (ORCPT <rfc822;w@1wt.eu>);
	Fri, 31 May 2013 03:58:15 -0400
Received: from cantor2.suse.de ([195.135.220.15]:39278 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751207Ab3EaH6G (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 31 May 2013 03:58:06 -0400
Date: Fri, 31 May 2013 09:58:45 +0200
Message-ID: <s5ha9nbinre.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Alan Stern <stern@rowland.harvard.edu>,
        alsa-devel@alsa-project.org,
        Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] Improving or replacing snd_printk()
In-Reply-To: <1369985881.10556.54.camel@joe-AO722>
References: <Pine.LNX.4.44L0.1305301411370.1137-100000@iolanthe.rowland.org>
	<51A79F25.6040007@perex.cz>
	<s5hr4gniri4.wl%tiwai@suse.de>
	<1369983967.10556.48.camel@joe-AO722>
	<s5hip1zipde.wl%tiwai@suse.de>
	<1369985409.10556.51.camel@joe-AO722>
	<s5hd2s7iouz.wl%tiwai@suse.de>
	<1369985881.10556.54.camel@joe-AO722>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1867
Lines: 44

At Fri, 31 May 2013 00:38:01 -0700,
Joe Perches wrote:
> 
> On Fri, 2013-05-31 at 09:35 +0200, Takashi Iwai wrote:
> > At Fri, 31 May 2013 00:30:09 -0700, Joe Perches wrote:
> > > On Fri, 2013-05-31 at 09:23 +0200, Takashi Iwai wrote:
> > > > At Fri, 31 May 2013 00:06:07 -0700, Joe Perches wrote:
> > > > > On Fri, 2013-05-31 at 08:37 +0200, Takashi Iwai wrote:
> > > > > > I think most of snd_printd() and snd_printdd() can be kept as is.
> > > > > > These are just debug messages, after all.
> > > > > Some of those are emitted at levels other than KERN_DEBUG.
> > > > > I think that odd.
> > > > Yeah, they aren't good, but it's a different topic.
> > > 
> > > Not really, I think it's systemic and fallout from
> > > accretive implementation rather than design.
> > 
> > Maybe.
> > 
> > But you shouldn't mix up with the fix for the missing verbosity and
> > the fix for wrong KERN_ prefix, at least, in the patch level.  They
> > need to be fixed individually.
> 
> I think that's best too.
> 
> I don't see the complexity/hell in adding functions
> for specific types of struct * to reduce the complexity
> of the code though.  Centralizing those indirections
> into functions also generally reduces overall code size.

I don't mind to add the struct pointer to new snd_*() -- if we really
introduce them.  The bigger question is whether we really need to
introduce such, and if yes, what variants.  And for that, I don't
think we need to add many functions.  Maybe snd_card_<level>() would
be good.  But others don't seem to make sense to me (remember that I
suggest dropping CONFIG_SND_VERBOSE_PRINTK).


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/