Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753144Ab3EaImz (ORCPT ); Fri, 31 May 2013 04:42:55 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:34714 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205Ab3EaImp (ORCPT ); Fri, 31 May 2013 04:42:45 -0400 Date: Fri, 31 May 2013 01:42:44 -0700 (PDT) Message-Id: <20130531.014244.1871655049070137342.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: mschiffer@universe-factory.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb From: David Miller In-Reply-To: References: <51A66CF3.7010202@universe-factory.net> <5578958b49fff222740711e091c2325100f5a440.1369963643.git.mschiffer@universe-factory.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 804 Lines: 22 From: Cong Wang Date: Fri, 31 May 2013 11:23:11 +0800 > On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer > wrote: >> Since some refactoring in 5f5a011, ndisc_send_redirect called >> ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or >> in the worst case a panic when the skb_put failed. >> >> Signed-off-by: Matthias Schiffer > > > Good catch! > > Reviewed-by: Cong Wang I've queued this up for -stable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/