Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754985Ab3EaK4R (ORCPT ); Fri, 31 May 2013 06:56:17 -0400 Received: from hermes.synopsys.com ([198.182.44.81]:48346 "EHLO hermes.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873Ab3EaK4L (ORCPT ); Fri, 31 May 2013 06:56:11 -0400 From: Vineet Gupta To: Andrew Morton CC: , , , Max Filippov , "Vineet Gupta" , Mel Gorman , Hugh Dickins , Rik van Riel , David Rientjes , Peter Zijlstra , Catalin Marinas , Alex Shi Subject: [PATCH 1/2] mm: Fix the TLB range flushed when __tlb_remove_page() runs out of slots Date: Fri, 31 May 2013 16:23:49 +0530 Message-ID: <1369997630-6522-2-git-send-email-vgupta@synopsys.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1369997630-6522-1-git-send-email-vgupta@synopsys.com> References: <1369997630-6522-1-git-send-email-vgupta@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.12.197.154] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1896 Lines: 64 zap_pte_range loops from @addr to @end. In the middle, if it runs out of batching slots, TLB entries needs to be flushed for @start to @interim, NOT @interim to @end. Since ARC port doesn't use page free batching I can't test it myself but this seems like the right thing to do. Observed this when working on a fix for the issue at thread: http://www.spinics.net/lists/linux-arch/msg21736.html Signed-off-by: Vineet Gupta Cc: Andrew Morton Cc: Mel Gorman Cc: Hugh Dickins Cc: Rik van Riel Cc: David Rientjes Cc: Peter Zijlstra Cc: linux-mm@kvack.org Cc: linux-arch@vger.kernel.org Cc: Catalin Marinas Cc: Max Filippov Cc: Alex Shi Acked-by: Catalin Marinas --- mm/memory.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 6dc1882..d9d5fd9 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1110,6 +1110,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, spinlock_t *ptl; pte_t *start_pte; pte_t *pte; + unsigned long range_start = addr; again: init_rss_vec(rss); @@ -1215,12 +1216,14 @@ again: force_flush = 0; #ifdef HAVE_GENERIC_MMU_GATHER - tlb->start = addr; - tlb->end = end; + tlb->start = range_start; + tlb->end = addr; #endif tlb_flush_mmu(tlb); - if (addr != end) + if (addr != end) { + range_start = addr; goto again; + } } return addr; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/