Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755932Ab3EaLew (ORCPT ); Fri, 31 May 2013 07:34:52 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:41578 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753278Ab3EaLep (ORCPT ); Fri, 31 May 2013 07:34:45 -0400 Date: Fri, 31 May 2013 13:34:41 +0200 From: Ingo Molnar To: Yinghai Lu Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Yuanhan Liu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86: Fix adjust_range_size_mask calling position Message-ID: <20130531113441.GB7131@gmail.com> References: <1369861769-30687-1-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369861769-30687-1-git-send-email-yinghai@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 28 * Yinghai Lu wrote: > Commit 8d57470d cause a kernel panic while setting mem=2G. > [mem 0x00000000-0x000fffff] page 4k > [mem 0x7fe00000-0x7fffffff] page 1G > [mem 0x7c000000-0x7fdfffff] page 1G > [mem 0x00100000-0x001fffff] page 4k > [mem 0x00200000-0x7bffffff] page 2M > > for last entry is not what we want, we should have > [mem 0x00200000-0x3fffffff] page 2M > [mem 0x40000000-0x7bffffff] page 1G What this changelog does not mention, why does the erroneous entry result in a kernel panic? It looks like a valid range, so a crash is unexpected. (This is worth explaining, even if the fix for that is in a separate patch.) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/