Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755629Ab3EaM5y (ORCPT ); Fri, 31 May 2013 08:57:54 -0400 Received: from mail-qe0-f43.google.com ([209.85.128.43]:33737 "EHLO mail-qe0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755349Ab3EaM5U (ORCPT ); Fri, 31 May 2013 08:57:20 -0400 MIME-Version: 1.0 In-Reply-To: <51A89ACE.8030604@st.com> References: <1369993439-24216-1-git-send-email-srinivas.kandagatla@st.com> <1369993501-24309-1-git-send-email-srinivas.kandagatla@st.com> <51A89ACE.8030604@st.com> From: Barry Song <21cnbao@gmail.com> Date: Fri, 31 May 2013 20:56:58 +0800 Message-ID: Subject: Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early To: srinivas.kandagatla@st.com Cc: Arnd Bergmann , Barry Song , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, DL-SHA-WorkGroupLinux Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 34 2013/5/31 Srinivas KANDAGATLA : > On 31/05/13 13:24, Barry Song wrote: >>> > Signed-off-by: Srinivas Kandagatla >> hi Sriniva, >> i think my "arm: prima2: move to generic reset controller driver >> framework" fixs this too: >> http://www.spinics.net/lists/arm-kernel/msg246206.html > I did look at the patch, I think it will fix it. > > But the patch is still using arch_initcall directly, which means this > call will be attempted by every SOC in multi_v7 kernel. > This call can be easily hooked into machine descriptor. > In that way only prima compatible machines will attempt to call this > function in first place. mine should fix panic as it returns 0 instead of using BUG(). but i do think we should merge yours too to avoid redundant execution path. > > Do you know if the second issue of postcore init is fixed in any other > patches. no. i will test your v2. > > thanks, > srini -barry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/