Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756172Ab3EaPUT (ORCPT ); Fri, 31 May 2013 11:20:19 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:44758 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731Ab3EaPUP (ORCPT ); Fri, 31 May 2013 11:20:15 -0400 Message-ID: <51A8BF90.4060509@ti.com> Date: Fri, 31 May 2013 10:19:44 -0500 From: Dan Murphy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Javier Martinez Canillas CC: , , , , , , Subject: Re: [PATCH v8] ARM: dts: omap4-panda: Update the LED support for the panda DTS References: <1370011682-20675-1-git-send-email-dmurphy@ti.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2730 Lines: 72 On 05/31/2013 10:05 AM, Javier Martinez Canillas wrote: > On Fri, May 31, 2013 at 4:48 PM, Dan Murphy wrote: >> The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es >> are different. >> >> A1-A3 = gpio_wk7 >> ES = gpio_110 >> >> There is no change to LED D2 >> >> Abstract away the pinmux and the LED definitions for the two boards into >> the respective DTS files. >> >> Signed-off-by: Dan Murphy >> --- >> v8 - Rebase to latest and use pinctrl macros - https://patchwork.kernel.org/patch/2629351/ >> v7 - Update headline to add spaces - https://patchwork.kernel.org/patch/2583661/ >> v6 - Review comments updated - https://patchwork.kernel.org/patch/2582771/ >> v5 - Provide pincrtl phandle to the gpio-led driver - https://patchwork.kernel.org/patch/2573981/ >> >> arch/arm/boot/dts/omap4-panda-common.dtsi | 16 +++++++++++++++- >> arch/arm/boot/dts/omap4-panda-es.dts | 28 ++++++++++++++++++++++++++++ >> 2 files changed, 43 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi >> index d5d144a..523a800 100644 >> --- a/arch/arm/boot/dts/omap4-panda-common.dtsi >> +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi >> @@ -16,8 +16,13 @@ >> reg = <0x80000000 0x40000000>; /* 1 GB */ >> }; >> >> - leds { >> + leds: leds { >> compatible = "gpio-leds"; >> + pinctrl-names = "default"; >> + pinctrl-0 = < >> + &led_wkgpio_pins >> + >; >> + >> heartbeat { >> label = "pandaboard::status1"; >> gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>; >> @@ -157,6 +162,15 @@ >> }; >> }; >> >> +&omap4_pmx_wkup { >> + led_wkgpio_pins: pinmux_leds_wkpins { >> + pinctrl-single,pins = < >> + 0x1a (PIN_OUTPUT | MUX_MODE3) /* gpio_wk7 OUTPUT | MODE 3 */ >> + 0x1c (PIN_OUTPUT | MUX_MODE3) /* gpio_wk8 OUTPUT | MODE 3 */ > Hello Dan, > > The OUTPUT | MODE 3 in the comments were added so people shouldn't > have to look at the TRM to find what each constant number meant. But > now using the macros this is not needed anymore, so I don't think is > necessary to keep that on the comments. > > Best regards, > Javier Yes you are correct sending update to remove the comments -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/