Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696Ab3EaREs (ORCPT ); Fri, 31 May 2013 13:04:48 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:54625 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992Ab3EaREm (ORCPT ); Fri, 31 May 2013 13:04:42 -0400 Date: Fri, 31 May 2013 10:04:37 -0700 From: Dmitry Torokhov To: Hebbar Gururaja Cc: khilman@linaro.org, grant.likely@linaro.org, linus.walleij@linaro.org, rob.herring@calxeda.com, davinci-linux-open-source@linux.davincidsp.com, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, vaibhav.bedia@ti.com, sudhakar.raj@ti.com Subject: Re: [PATCH 00/11] drivers: Add Pinctrl PM support Message-ID: <20130531170437.GA17591@core.coreip.homeip.net> References: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1468 Lines: 37 Hi Hebbar, On Fri, May 31, 2013 at 03:43:00PM +0530, Hebbar Gururaja wrote: > By optionally putting the pins into sleep state in the suspend [or in > runtime_suspend] callback we can accomplish two things. > - One is to minimize current leakage from pins and thus save power, > - second, we can prevent the IP from driving pins output in an > uncontrolled manner, which may happen if the power domain drops the > domain regulator. > > These states can be specified in the DT blob and corresponding driver > can pick these states during probe & set the related values during > idle/suspend. > > Not all drivers support/has idle state. Drivers like i2c, spi, mmc has > idle states and hence these drivers are updated to support all the > three states > - default : during regular operation > - idle : when the module is in idle state > - sleep : when the module is in suspend state > > For those drivers which doesn't support/have idle state (at least at > the moment), only default & sleep state is added. As with the original introduction of pinctrl states my question is: "Can all of this be handled in the driver/bus core instead of adding a lot of boilerplate code to the individual drivers". Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/