Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756853Ab3FAExR (ORCPT ); Sat, 1 Jun 2013 00:53:17 -0400 Received: from gate.crashing.org ([63.228.1.57]:53253 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427Ab3FAExK (ORCPT ); Sat, 1 Jun 2013 00:53:10 -0400 Message-ID: <1370062367.3766.30.camel@pasglop> Subject: Re: [PATCH v3 8/8] powerpc/pseries: Read common partition via pstore From: Benjamin Herrenschmidt To: Aruna Balakrishnaiah Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org, jkenisto@linux.vnet.ibm.com, tony.luck@intel.com, ananth@in.ibm.com, mahesh@linux.vnet.ibm.com, ccross@android.com, anton@samba.org, cbouatmailru@gmail.com, keescook@chromium.org Date: Sat, 01 Jun 2013 14:52:47 +1000 In-Reply-To: <20130425101908.21017.32553.stgit@aruna-ThinkPad-T420> References: <20130425100952.21017.51799.stgit@aruna-ThinkPad-T420> <20130425101908.21017.32553.stgit@aruna-ThinkPad-T420> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 48 On Thu, 2013-04-25 at 15:49 +0530, Aruna Balakrishnaiah wrote: > diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c > index 8d4fb65..88cc050 100644 > --- a/fs/pstore/inode.c > +++ b/fs/pstore/inode.c > @@ -330,6 +330,9 @@ int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count, > case PSTORE_TYPE_PPC_OF: > sprintf(name, "of-%s-%lld", psname, id); > break; Call this powerpc-ofw-... Does it even contain something we use in Linux at all ? Last I looked we only used the common one right ? Also it's format afaik is defined in the CHRP bindings so it's not generic OFW stuff, hence the powerpc prefix. > + case PSTORE_TYPE_PPC_COMMON: > + sprintf(name, "common-%s-%lld", psname, id); > + break; Same deal, call that powerpc-common > case PSTORE_TYPE_UNKNOWN: > sprintf(name, "unknown-%s-%lld", psname, id); > break; > diff --git a/include/linux/pstore.h b/include/linux/pstore.h > index 615dc18..656699f 100644 > --- a/include/linux/pstore.h > +++ b/include/linux/pstore.h > @@ -38,6 +38,7 @@ enum pstore_type_id { > /* PPC64 partition types */ > PSTORE_TYPE_PPC_RTAS = 4, > PSTORE_TYPE_PPC_OF = 5, > + PSTORE_TYPE_PPC_COMMON = 6, > PSTORE_TYPE_UNKNOWN = 255 > }; Do we expose anything else or keep it hidden ? Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/