From: Arnd Bergmann <arnd@arndb.de>
To: Jan Luebbe <jlu@pengutronix.de>
Subject: Re: [PATCH v2] pps-gpio: add device-tree binding and support
Date: Sat, 1 Jun 2013 13:44:35 +0200
User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; )
Cc: Grant Likely <grant.likely@linaro.org>,
        Rob Herring <rob.herring@calxeda.com>,
        Rodolfo Giometti <giometti@enneenne.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1588516.WvWWFWzAui@wuerfel> <1370083449-11986-1-git-send-email-jlu@pengutronix.de>
In-Reply-To: <1370083449-11986-1-git-send-email-jlu@pengutronix.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201306011344.36214.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 682
Lines: 15

On Saturday 01 June 2013, Jan Luebbe wrote:
> Instead of allocating a struct pps_gpio_platform_data in the DT case, store
> the necessary information in struct pps_gpio_device_data itself. This avoids
> an additional allocation and the ifdef. It also gets rid of some indirection.
> 
> Also use dev_err instead of pr_err in the changed code.
> 
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> 
Acked-by: Arnd Bergmann <arnd@arndb.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/