Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757075Ab3FANPH (ORCPT ); Sat, 1 Jun 2013 09:15:07 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:44408 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756482Ab3FANPF (ORCPT ); Sat, 1 Jun 2013 09:15:05 -0400 MIME-Version: 1.0 In-Reply-To: <51A926A4.5010800@infradead.org> References: <1370031778-25965-1-git-send-email-emilgoode@gmail.com> <51A926A4.5010800@infradead.org> Date: Sat, 1 Jun 2013 16:15:03 +0300 Message-ID: Subject: Re: [PATCH] usb: musb: Fix format specifier warning From: Andy Shevchenko To: Randy Dunlap Cc: Emil Goode , balbi@ti.com, Greg Kroah-Hartman , USB , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 29 On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote: > On 05/31/13 15:34, Andy Shevchenko wrote: >> On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >>> This patch fixes a format specifier warning. dma_addr_t can be either >>> u32 or u64 so we should cast to the largest type and change the format >>> specifier to %llx. >> >> dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier >> which is available from v3.8(?). >> >> Something like this: >> dma_addr_t src_addr; >> dev_dbg(dev, "DMA addr: %pa\n", src_addr); > > Isn't that: > > deb_dbg(dev, "DMA addr: %pa\n", &src_addr); It's. You are right. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/