Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358Ab3FAP2o (ORCPT ); Sat, 1 Jun 2013 11:28:44 -0400 Received: from mail.active-venture.com ([67.228.131.205]:53169 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866Ab3FAP2g (ORCPT ); Sat, 1 Jun 2013 11:28:36 -0400 X-Originating-IP: 108.223.40.66 Date: Sat, 1 Jun 2013 08:29:09 -0700 From: Guenter Roeck To: Michal Simek Cc: linux-kernel@vger.kernel.org, Michal Simek , Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2 1/2] watchdog: xilinx: Fix driver header Message-ID: <20130601152909.GB7751@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2537 Lines: 70 On Fri, May 31, 2013 at 07:56:33AM +0200, Michal Simek wrote: > - Remove reference for IP version > - Fix header coding style > - Remove notes which are visible from the code > - Fix driver license according to header > > Signed-off-by: Michal Simek Reviewed-by: Guenter Roeck > --- > Changes in v2: None > > drivers/watchdog/of_xilinx_wdt.c | 30 ++++++++++-------------------- > 1 file changed, 10 insertions(+), 20 deletions(-) > > diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c > index 2761ddb..d4a35ab 100644 > --- a/drivers/watchdog/of_xilinx_wdt.c > +++ b/drivers/watchdog/of_xilinx_wdt.c > @@ -1,23 +1,13 @@ > /* > -* of_xilinx_wdt.c 1.01 A Watchdog Device Driver for Xilinx xps_timebase_wdt > -* > -* (C) Copyright 2011 (Alejandro Cabrera ) > -* > -* ----------------------- > -* > -* This program is free software; you can redistribute it and/or > -* modify it under the terms of the GNU General Public License > -* as published by the Free Software Foundation; either version > -* 2 of the License, or (at your option) any later version. > -* > -* ----------------------- > -* 30-May-2011 Alejandro Cabrera > -* - If "xlnx,wdt-enable-once" wasn't found on device tree the > -* module will use CONFIG_WATCHDOG_NOWAYOUT > -* - If the device tree parameters ("clock-frequency" and > -* "xlnx,wdt-interval") wasn't found the driver won't > -* know the wdt reset interval > -*/ > + * Watchdog Device Driver for Xilinx axi/xps_timebase_wdt > + * > + * (C) Copyright 2011 (Alejandro Cabrera ) > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version > + * 2 of the License, or (at your option) any later version. > + */ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > @@ -413,5 +403,5 @@ module_platform_driver(xwdt_driver); > > MODULE_AUTHOR("Alejandro Cabrera "); > MODULE_DESCRIPTION("Xilinx Watchdog driver"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); > -- > 1.8.2.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/