Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007Ab3FAPaa (ORCPT ); Sat, 1 Jun 2013 11:30:30 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:49766 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815Ab3FAPaV (ORCPT ); Sat, 1 Jun 2013 11:30:21 -0400 From: Laurent Pinchart To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, patches@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Konstantin Khlebnikov Subject: Re: [PATCH 13/15] [media] omap3isp: include linux/mm_types.h Date: Sat, 01 Jun 2013 17:30:17 +0200 Message-ID: <3507557.BiLMFItQuE@avalon> User-Agent: KMail/4.10.2 (Linux/3.8.13-gentoo; KDE/4.10.2; x86_64; ; ) In-Reply-To: <1370038972-2318779-14-git-send-email-arnd@arndb.de> References: <1370038972-2318779-1-git-send-email-arnd@arndb.de> <1370038972-2318779-14-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 51 Hi Arnd, Thank you for the patch. On Saturday 01 June 2013 00:22:50 Arnd Bergmann wrote: > The ispqueue.h file uses vm_flags_t, which is defined in > linux/mm_types.h, so we must include that header in order > to build in all configurations. > > Signed-off-by: Arnd Bergmann > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Cc: Konstantin Khlebnikov > Cc: Laurent Pinchart Acked-by: Laurent Pinchart (with a minor nitpick below) > --- > drivers/media/platform/omap3isp/ispqueue.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/omap3isp/ispqueue.h > b/drivers/media/platform/omap3isp/ispqueue.h index 908dfd7..e6e720c 100644 > --- a/drivers/media/platform/omap3isp/ispqueue.h > +++ b/drivers/media/platform/omap3isp/ispqueue.h > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include Could you please make sure the headers are sorted alphabetically ? Would you like me to take the patch in my tree ? If so I'll sort the headers myself. > struct isp_video_queue; > struct page; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/