Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753822Ab3FAUaQ (ORCPT ); Sat, 1 Jun 2013 16:30:16 -0400 Received: from mail-qe0-f51.google.com ([209.85.128.51]:45643 "EHLO mail-qe0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325Ab3FAUaN (ORCPT ); Sat, 1 Jun 2013 16:30:13 -0400 Message-ID: <51AA59D0.7020805@gmail.com> Date: Sat, 01 Jun 2013 15:30:08 -0500 From: Rob Herring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 MIME-Version: 1.0 To: Arnd Bergmann CC: "linux-kernel@vger.kernel.org" , Grant Likely , patches@lists.linaro.org, Rob Herring , "linux-arm-kernel@lists.infradead.org" , Benjamin Herrenschmidt Subject: Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h References: <1370038972-2318779-1-git-send-email-arnd@arndb.de> <1370038972-2318779-16-git-send-email-arnd@arndb.de> <201306012203.39133.arnd@arndb.de> In-Reply-To: <201306012203.39133.arnd@arndb.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 33 On 06/01/2013 03:03 PM, Arnd Bergmann wrote: > On Saturday 01 June 2013, Rob Herring wrote: >> On Fri, May 31, 2013 at 5:22 PM, Arnd Bergmann wrote: >>> A lot of code uses the functions from of_platform.h when built for >>> devicetree-enabled platforms but can also be built without them. >>> In order to avoid using #ifdef everywhere in drivers, this >>> makes all the function declarations visible, which means we >>> can use "if (IS_ENABLED(CONFIG_OF))" in driver code and get build >>> coverage over the code but let the compiler drop the reference >>> in the object code. >>> >>> Signed-off-by: Arnd Bergmann >>> Cc: Grant Likely >>> Cc: Rob Herring >> >> I've got a more complete series for 3.11 that removes OF_DEVICE and >> of_platform_driver completely. I'm waiting on ack from Ben H. > > Ok. Does your series also remove the #ifdef CONFIG_OF part from this > header? No, we still need empty functions. Here is what of_device.h looks like: http://tinyurl.com/l2azz5m BTW, it has your ack. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/