Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247Ab3FBCvS (ORCPT ); Sat, 1 Jun 2013 22:51:18 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:50185 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779Ab3FBCvQ (ORCPT ); Sat, 1 Jun 2013 22:51:16 -0400 MIME-Version: 1.0 In-Reply-To: <20130528084833.GA30172@gmail.com> References: <1369211258-3163-1-git-send-email-namhyung@kernel.org> <1369211258-3163-4-git-send-email-namhyung@kernel.org> <20130522095215.GA2386@ghostprotocols.net> <20130528084833.GA30172@gmail.com> From: Namhyung Kim Date: Sun, 2 Jun 2013 11:50:55 +0900 X-Google-Sender-Auth: AIGrRKwPa847ycuLFkBj8qLuk9I Message-ID: Subject: Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also To: Ingo Molnar Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Namhyung Kim , LKML , Jiri Olsa , David Ahern , Stephane Eranian , Pekka Enberg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 45 Hi Ingo, On Tue, May 28, 2013 at 5:48 PM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu: >> > From: Namhyung Kim >> > >> > Add a new column for showing callchain overhead. I feel like it's >> > more natural than having those overhead next to a first child in a >> > same column. >> >> Callchains in GTK, great! Some observations tho: >> >> All those leaves with 0.00% looks ugly/not needed, right? >> >> I took a screenshot and put at: >> >> http://vger.kernel.org/~acme/perf-gtk-callchains.png > > Looks really nice! Thanks! :) > > I'm wondering, would it be hard to add alternating lightgrey+white > background colors to make the entries striped and for the horizontal > structure to thus stand out better? > > The 'qgit' tool does that for example, to alternate git commit log > entries. > > (Extra points for striping only where the line actually begins.) It should be easy, I'll add it in the next spin. -- Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/