Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751392Ab3FCESS (ORCPT ); Mon, 3 Jun 2013 00:18:18 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:45808 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074Ab3FCESO (ORCPT ); Mon, 3 Jun 2013 00:18:14 -0400 Message-ID: <51AC18FF.9010108@linaro.org> Date: Mon, 03 Jun 2013 09:48:07 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: t.figa@gmail.com CC: Sylwester Nawrocki , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, arnd@arndb.de, kgene.kim@samsung.com, olof@lixom.net, patches@linaro.org Subject: Re: [PATCH 3/3] ARM: S5P64X0: Remove duplicate uncompress code References: <1370000944-19786-1-git-send-email-tushar.behera@linaro.org> <1370000944-19786-4-git-send-email-tushar.behera@linaro.org> <51A9B3BC.9000405@gmail.com> In-Reply-To: <51A9B3BC.9000405@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 40 On 06/01/2013 02:11 PM, Sylwester Nawrocki wrote: > Hi, > > On 05/31/2013 01:49 PM, Tushar Behera wrote: >> The uncompress code in S5P64X0 is almost same as the uncompress code >> defined in plat-samsung. Better to reuse that code. >> >> Signed-off-by: Tushar Behera >> --- >> arch/arm/mach-s5p64x0/include/mach/uncompress.h | 163 >> ++--------------------- >> 1 file changed, 8 insertions(+), 155 deletions(-) > > Not sure if you are aware of it, Tomasz has already posted a patch that > removes this duplicated code: https://patchwork.kernel.org/patch/2589331 > I think that patch is not yet merged though. > > Regards, > Sylwester Tomasz, I had somehow missed that mail. The patch that I have additionally makes calculation of uart_base conditional on DEBUG_LL in line with the rest of the patches. Would you mind re-spining your patch with those changes? Alternately, I can take your patch and do above modifications in them. Let me know your opinion on this. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/