Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752539Ab3FCG2N (ORCPT ); Mon, 3 Jun 2013 02:28:13 -0400 Received: from mail-we0-f182.google.com ([74.125.82.182]:48579 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab3FCG2K (ORCPT ); Mon, 3 Jun 2013 02:28:10 -0400 Message-ID: <51AC376D.9030001@redhat.com> Date: Mon, 03 Jun 2013 08:27:57 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Gleb Natapov CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] KVM: fix sil/dil/bpl/spl in the mod/rm fields References: <1369924555-30216-1-git-send-email-pbonzini@redhat.com> <20130602181253.GP24773@redhat.com> In-Reply-To: <20130602181253.GP24773@redhat.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1894 Lines: 57 Il 02/06/2013 20:12, Gleb Natapov ha scritto: > On Thu, May 30, 2013 at 04:35:55PM +0200, Paolo Bonzini wrote: >> The x86-64 extended low-byte registers were fetched correctly from reg, >> but not from mod/rm. >> >> This fixes another bug in the boot of RHEL5.9 64-bit, but it is still >> not enough. >> > Did I missed unit test patch? :) I wanted to ask the GSoC student to do it. If it doesn't come in a couple of weeks, I'll send it. Paolo >> Cc: gnatapov@redhat.com >> Cc: kvm@vger.kernel.org >> Cc: # 3.9 >> Signed-off-by: Paolo Bonzini >> --- >> arch/x86/kvm/emulate.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c >> index aa68106..028b34f 100644 >> --- a/arch/x86/kvm/emulate.c >> +++ b/arch/x86/kvm/emulate.c >> @@ -1239,9 +1239,12 @@ static int decode_modrm(struct x86_emulate_ctxt *ctxt, >> ctxt->modrm_seg = VCPU_SREG_DS; >> >> if (ctxt->modrm_mod == 3) { >> + int highbyte_regs = ctxt->rex_prefix == 0; >> + >> op->type = OP_REG; >> op->bytes = (ctxt->d & ByteOp) ? 1 : ctxt->op_bytes; >> - op->addr.reg = decode_register(ctxt, ctxt->modrm_rm, ctxt->d & ByteOp); >> + op->addr.reg = decode_register(ctxt, ctxt->modrm_rm, >> + highbyte_regs && (ctxt->d & ByteOp)); >> if (ctxt->d & Sse) { >> op->type = OP_XMM; >> op->bytes = 16; >> -- >> 1.8.1.4 > > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/