Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752823Ab3FCItD (ORCPT ); Mon, 3 Jun 2013 04:49:03 -0400 Received: from eu1sys200aog119.obsmtp.com ([207.126.144.147]:46116 "EHLO eu1sys200aog119.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100Ab3FCIs7 (ORCPT ); Mon, 3 Jun 2013 04:48:59 -0400 Message-ID: <51AC5827.4040801@st.com> Date: Mon, 03 Jun 2013 09:47:35 +0100 From: Srinivas KANDAGATLA Reply-To: srinivas.kandagatla@st.com Organization: STMicroelectronics User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Barry Song <21cnbao@gmail.com> Cc: Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Barry Song Subject: Re: [PATCH v1 1/2] ARM:prima2: move sirfsoc_of_rstc_init to .init_early References: <1369993439-24216-1-git-send-email-srinivas.kandagatla@st.com> <1369993501-24309-1-git-send-email-srinivas.kandagatla@st.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1918 Lines: 46 Hi Barry, Thanks for testing, I think this patch introduced a sequencing issue. Just re-looking at the code, is there any reason for this to be init_earlycall? And do a ioremap at that early stage? Can't we move it to device_init level function "sirfsoc_mach_init()" at which it will be safe to do a ioremap with all mm setup finished? Thanks, srini On 03/06/13 03:19, Barry Song wrote: > this broke SiRF by: > Uncompressing Linux... done, booting the kernel. > [ 0.000000] Booting Linux on physical CPU 0x0 > [ 0.000000] Linux version 3.10.0-rc2-00723-gd1a0472-dirty > (barry@barry-laptop) (gcc version 4.5.4 20110505 (prerelease) > (Ubuntu/Linaro 4.5-2011.5-csr-build) ) #35 SMP PREEMPT Mon Jun 3 > 09:51:59 CST 2013 > [ 0.000000] CPU: ARMv7 Processor [413fc090] revision 0 (ARMv7), cr=10c53c7d > [ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing > instruction cache > [ 0.000000] Machine: Generic ATLAS6 (Flattened Device Tree), model: > CSR SiRFatlas6 Evaluation Board > [ 0.000000] bootconsole [earlycon0] enabled > [ 0.000000] Memory policy: ECC disabled, Data cache writealloc > [ 0.000000] Unable to handle kernel NULL pointer dereference at > virtual address 00000000 > [ 0.000000] pgd = c0004000 > [ 0.000000] [00000000] *pgd=00000000 > [ 0.000000] Internal error: Oops: 5 [#1] PREEMPT SMP ARM > [ 0.000000] Modules linked in: > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted > 3.10.0-rc2-00723-gd1a0472-dirty #35 > [ 0.000000] task: c05cfb40 ti: c05c4000 task.ti: c05c4000 > [ 0.000000] PC is at kmem_cache_alloc+0x2c/0x124 > [ 0.000000] LR is at __get_vm_area_node.clone.26+0x7c/0x190 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/