Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756705Ab3FCJzm (ORCPT ); Mon, 3 Jun 2013 05:55:42 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:56745 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755981Ab3FCJzj (ORCPT ); Mon, 3 Jun 2013 05:55:39 -0400 Date: Mon, 3 Jun 2013 10:54:25 +0100 From: Will Deacon To: "Wang, Yalin" Cc: "'richard -rw- weinberger'" , "'linux-arch@vger.kernel.org'" , "'linux-kernel@vger.kernel.org'" , "'linux-arm-kernel@lists.infradead.org'" Subject: Re: A bug about system call on ARM Message-ID: <20130603095425.GA32242@mudshark.cambridge.arm.com> References: <35FD53F367049845BC99AC72306C23D1610991B865@CNBJMBX05.corpusers.net> <35FD53F367049845BC99AC72306C23D1610991B866@CNBJMBX05.corpusers.net> <20130530090949.GC7483@mudshark.cambridge.arm.com> <20130530114112.GH7483@mudshark.cambridge.arm.com> <35FD53F367049845BC99AC72306C23D1610991B86D@CNBJMBX05.corpusers.net> <20130531084638.GB4928@mudshark.cambridge.arm.com> <35FD53F367049845BC99AC72306C23D1610991B874@CNBJMBX05.corpusers.net> <20130531111305.GI4928@mudshark.cambridge.arm.com> <35FD53F367049845BC99AC72306C23D1610991B876@CNBJMBX05.corpusers.net> <35FD53F367049845BC99AC72306C23D1610991B87B@CNBJMBX05.corpusers.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35FD53F367049845BC99AC72306C23D1610991B87B@CNBJMBX05.corpusers.net> Thread-Topic: A bug about system call on ARM Accept-Language: en-GB, en-US Content-Language: en-US User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 671 Lines: 25 On Mon, Jun 03, 2013 at 06:25:26AM +0100, Wang, Yalin wrote: > Hi Will, > > I have a question about this patch . > > If the user space is thumb mode, > The PC should be rewind by 2 bytes, > So the fix_up code should be > > Sub lr, lr, #2 . > > > Am I right ? No, because we don't have OABI-compat support for Thumb applications and force everything down the EABI path instead. Did you manage to test the patch? Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/