From: Tomasz Figa <t.figa@samsung.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: t.figa@gmail.com, Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, arnd@arndb.de,
        kgene.kim@samsung.com, olof@lixom.net, patches@linaro.org
Subject: Re: [PATCH 3/3] ARM: S5P64X0: Remove duplicate uncompress code
Date: Mon, 03 Jun 2013 13:40:49 +0200
Message-id: <13570629.4jzYey0dyq@amdc1227>
Organization: Samsung Poland R&D Center
User-Agent: KMail/4.10.2 (Linux/3.8.8-gentoo; KDE/4.10.2; x86_64; ; )
In-reply-to: <51AC18FF.9010108@linaro.org>
References: <1370000944-19786-1-git-send-email-tushar.behera@linaro.org>
 <51A9B3BC.9000405@gmail.com> <51AC18FF.9010108@linaro.org>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1802
Lines: 59

Hi Tushar,

On Monday 03 of June 2013 09:48:07 Tushar Behera wrote:
> On 06/01/2013 02:11 PM, Sylwester Nawrocki wrote:
> > Hi,
> > 
> > On 05/31/2013 01:49 PM, Tushar Behera wrote:
> >> The uncompress code in S5P64X0 is almost same as the uncompress code
> >> defined in plat-samsung. Better to reuse that code.
> >> 
> >> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> >> ---
> >> 
> >>   arch/arm/mach-s5p64x0/include/mach/uncompress.h |  163
> >> 
> >> ++---------------------
> >> 
> >>   1 file changed, 8 insertions(+), 155 deletions(-)
> > 
> > Not sure if you are aware of it, Tomasz has already posted a patch that
> > removes this duplicated code: https://patchwork.kernel.org/patch/2589331
> > I think that patch is not yet merged though.
> > 
> > Regards,
> > Sylwester
> 
> Tomasz,
> 
> I had somehow missed that mail.
> 
> The patch that I have additionally makes calculation of uart_base
> conditional on DEBUG_LL in line with the rest of the patches.
> 
> Would you mind re-spining your patch with those changes?
> 
> Alternately, I can take your patch and do above modifications in them.

Unfortunately I'm unlikely to find time to do it myself in nearest future, so 
feel free to do it. Thanks.

Keep in mind, however, that this patch was a dependency of

[PATCH 0/6] Samsung watchdog support clean-up
http://thread.gmane.org/gmane.linux.kernel.samsung-soc/18736/focus=18951

so I would like to keep this series applicable.

Best regards,
-- 
Tomasz Figa
Linux Kernel Developer
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/