Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758962Ab3FCPpM (ORCPT ); Mon, 3 Jun 2013 11:45:12 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:47504 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758921Ab3FCPpI (ORCPT ); Mon, 3 Jun 2013 11:45:08 -0400 From: Jiang Liu To: Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Jerome Marchand Cc: Yijing Wang , Jiang Liu , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v1 6/8] zram: avoid access beyond the zram device Date: Mon, 3 Jun 2013 23:42:18 +0800 Message-Id: <1370274140-26420-7-git-send-email-jiang.liu@huawei.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1370274140-26420-1-git-send-email-jiang.liu@huawei.com> References: <1370274140-26420-1-git-send-email-jiang.liu@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 31 Function valid_io_request() should verify the entire request doesn't exceed the zram device, otherwise it will cause invalid memory access. Signed-off-by: Jiang Liu --- drivers/staging/zram/zram_drv.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index 66cf28a..64b51b9 100644 --- a/drivers/staging/zram/zram_drv.c +++ b/drivers/staging/zram/zram_drv.c @@ -428,6 +428,10 @@ static inline int valid_io_request(struct zram *zram, struct bio *bio) return 0; } + if (unlikely((bio->bi_sector << SECTOR_SHIFT) + bio->bi_size >= + zram->disksize)) + return 0; + /* I/O request is valid */ return 1; } -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/