Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759110Ab3FCQ01 (ORCPT ); Mon, 3 Jun 2013 12:26:27 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:43868 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752767Ab3FCQ00 (ORCPT ); Mon, 3 Jun 2013 12:26:26 -0400 Date: Mon, 3 Jun 2013 17:25:18 +0100 From: Catalin Marinas To: Stefano Stabellini Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" , Will Deacon , "Ian.Campbell@citrix.com" , "konrad.wilk@oracle.com" Subject: Re: [PATCH v2 5/5] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64 Message-ID: <20130603162517.GC32295@arm.com> References: <1370273624-26976-5-git-send-email-stefano.stabellini@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370273624-26976-5-git-send-email-stefano.stabellini@eu.citrix.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 26 On Mon, Jun 03, 2013 at 04:33:44PM +0100, Stefano Stabellini wrote: > --- /dev/null > +++ b/arch/arm64/xen/hypercall.S ... > +/* > + * The Xen hypercall calling convention is very similar to the ARM AEBI > + * procedure calling convention: the first paramter is passed in x0, the > + * second in x1, the third in x2 and the fourth in x3. Considering that > + * Xen hypercalls have 5 arguments at most, the fifth paramter is passed > + * in rx, differently from the procedure calling convention of using the > + * stack for that case. You may want to use the AArch64 ABI here where parameters are passed in x0-x7, return in x0. BTW, I think it's missing a MAINTAINERS file update. Otherwise, the series looks good. How do you plan to upstream this? -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/